Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain optax to 0.1.x #992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IamJeffG
Copy link

@IamJeffG IamJeffG commented Feb 6, 2024

This assists downstream users of scenic (example: see google-research/perch#613) by constraining scenic's dependency on optax to

  1. a specific minor version: as optax is still a 0.y.z project we might assume that the 0.1.z to 0.2.0 change contains breaking changes.
  2. actual releases of optax, not a github URL

Disclaimer: I don't know this history behind the extant dependency specification, e.bg. maybe there was a reason scenic needs to rely on bleeding-edge pre-release code. Would the scenic authors be amenable to my change?

Copy link

google-cla bot commented Feb 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@IamJeffG
Copy link
Author

I think this is still the right thing to do, and all contributors are covered under a CLA. Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant